Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display missing checkboxes for workers under Diagnostics #5223

Merged
merged 1 commit into from Feb 6, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Feb 6, 2019

The server diagnostics page under settings was not displaying checkboxes, so it was not possible to restart the workers using the toolbar button. Setting the correct instance variable to true fixes the issue, specs are added to keep @martinpovolny happy.

Before:
screenshot from 2019-02-06 14-27-42

After:
screenshot from 2019-02-06 14-26-24

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672758

@miq-bot assign @h-kataria
@miq-bot add_label bug

@miq-bot miq-bot added the bug label Feb 6, 2019
@mzazrivec mzazrivec assigned mzazrivec and unassigned h-kataria Feb 6, 2019
@mzazrivec mzazrivec added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 6, 2019
@mzazrivec mzazrivec merged commit ade69c2 into ManageIQ:master Feb 6, 2019
@skateman skateman deleted the worker-checkbox branch February 7, 2019 17:22
simaishi pushed a commit that referenced this pull request Feb 7, 2019
Display missing checkboxes for workers under Diagnostics

(cherry picked from commit ade69c2)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1673747
@simaishi
Copy link
Contributor

simaishi commented Feb 7, 2019

Hammer backport details:

$ git log -1
commit cf628f86df9c1fb3db1ca6ed0e013b71b91faada
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Feb 6 10:48:05 2019 +0100

    Merge pull request #5223 from skateman/worker-checkbox
    
    Display missing checkboxes for workers under Diagnostics
    
    (cherry picked from commit ade69c24de34614bba1c22c1ee73a9c2ca32148d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1673747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants