Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display missing checkboxes for workers under Diagnostics #5223

Merged
merged 1 commit into from Feb 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/ops_controller/diagnostics.rb
Expand Up @@ -529,7 +529,7 @@ def refresh_server_summary
def pm_get_workers
@lastaction = "pm_workers_list"
@force_no_grid_xml = true
@no_checkboxes = true
@no_checkboxes = false
@gtl_type = "list"
@embedded = @pages = false
@showlinks = true
Expand Down
26 changes: 26 additions & 0 deletions spec/controllers/ops_controller/diagnostics_spec.rb
Expand Up @@ -57,6 +57,32 @@

describe OpsController do
render_views

describe '#report_data' do
before do
stub_user(:features => :all)
EvmSpecHelper.create_guid_miq_server_zone
FactoryBot.create(:miq_worker, :miq_server => server)
end

let(:server) { FactoryBot.create(:miq_server) }

it 'returns workers with checkboxes' do
report_data_request(
:model => 'MiqWorker',
:parent_id => nil,
:named_scope => [['with_miq_server_id', server.id]],
:explorer => true,
:gtl_dbname => nil,
:gtl_type => 'list'
)
results = assert_report_data_response
expect(results['data']['rows'].length).to eq(1)
expect(results['data']['rows'][0]["cells"][0]).to have_key("is_checkbox")
expect(results['data']['rows'][0]["cells"][0]["is_checkbox"]).to be_truthy
end
end

context "#tree_select" do
it "renders zone list for diagnostics_tree root node" do
stub_user(:features => :all)
Expand Down