Don't lookup category names if tag tree view all #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was executing a few hundred extra queries category.name is the culprit https://bugzilla.redhat.com/show_bug.cgi?id=1399345
|
Checked commit kbrock@0a4598a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Tested in UI. LGTM 👍 |
|
thanks Zita |
|
Backported to Euwe via ManageIQ/manageiq#13308 |
|
@kbrock because of https://bugzilla.redhat.com/show_bug.cgi?id=1412441, I'm adding |
|
Backported to Darga via ManageIQ/manageiq#13475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the tag tree in access control groups, the tag tree is not expandable. But building the node name (using
category.name) executes a few hundred extra queries (20%).This skips those queries.
Numbers are for small 5_7 db. numbers in larger DBS will increase for each tag and node in the db. They were timing out for me
/ops/explorerbefore/ops/exploreraftereuwe: [EUWE] Don't lookup category names if tag tree view all manageiq#13308