Commits on Jul 25, 2019

1. user_input_filter - don't send Cancel on Apply …

   Since #3444 (which fixed the user input filter modal to hide after Apply):
   
   * clicking the apply button triggers a ?button=apply request
   * but, thanks to data-dismiss="modal", it also closes the modal
   * BUT, closing the modal this way triggers a ?button=cancel request
   
   Thus, clicking apply triggers apply & cancel, in random order.
   
   Ideally, we should not be using data-dismiss on the Apply button,
   but using `$('#quicksearchbox').modal('hide')` in `quick_search_apply_click`, same as in `quick_search_cancel_click`.
   
   The problem with that is that this would involve changing every single `replace_right_cell`, or somehow amending their output after the fact.
   
   So, leaving the data-dismiss mechanism as is, but:
   
   * explicitly adding code to not send the ?button=cancel request when the Apply button was clicked
   * explicitly triggering hiding the modal when enter was clicked in the form (previously it would just apply)
   
   Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1715550

   

   himdel committed Jul 25, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for d25f5ed
   • Browse repository at this point

   Copy the full SHA

   d25f5ed View commit details

   Browse the repository at this point in the history