Call miqCheckForChanges before changing tabs.
#6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
reviewed
Nov 20, 2019
| miqObserveRequest(url + urlParams, {beforeSend: true}) | ||
| .catch(function (err) { | ||
| add_flash(__('Error requesting data from server'), 'error'); | ||
| console.log(err); |
There was a problem hiding this comment.
I'd suggest to replace this console.log with console.error or console.warn cc @himdel
|
What happens in forms with tabs? |
|
@himdel good point, trying that now |
h-kataria
changed the title
miqCheckForChanges before changing tabs.miqCheckForChanges before changing tabs.
This will force user to save any unsaved changes in the form before changing the tab. Issue ManageIQ#6213
h-kataria
force-pushed
the
abandon_changes_prompt_in_forms_with_tabs
branch
from
e11a7df
to
6b3f64d
Compare
Tweaked changes from previous commit to avoid abandon changes prompt when switching between tabs within the form(for the tabs that tabs are part of form) Issue ManageIQ#6213
h-kataria
force-pushed
the
abandon_changes_prompt_in_forms_with_tabs
branch
from
9b5b12e
to
0feea60
Compare
|
Checked commits h-kataria/manageiq-ui-classic@6b3f64d~...b47aa19 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@himdel fixed code to address tab change in the two forms with tabs that send transaction upto the server when tabs are switched. Ready to test/review. |
h-kataria
changed the title
miqCheckForChanges before changing tabs.miqCheckForChanges before changing tabs.
|
LGTM, tested in server settings (each tab is its own form, checks when switching & unsaved), 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will force user to save any unsaved changes in the form before changing the tab.
Issue #6213
Prompts user if they want to abandon changes after they have made changes to the form and trying to change the tabs in Configuration explorer. Tested this on several screens in OPS explorer, tried several other screens with tabs, seems to be working fine now. @hstastna please test