Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call miqCheckForChanges before changing tabs. #6431

Merged
merged 3 commits into from Nov 21, 2019
Merged

Call miqCheckForChanges before changing tabs. #6431

merged 3 commits into from Nov 21, 2019

Commits on Nov 20, 2019

  1. Call miqCheckForChanges before changing tabs. 

    This will force user to save any unsaved changes in the form before changing the tab.

Issue ManageIQ#6213
    @h-kataria
    h-kataria committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    6b3f64d View commit details
    Browse the repository at this point in the history

  2. Dont check for abandon changes within the form 

    Tweaked changes from previous commit to avoid abandon changes prompt when switching between tabs within the form(for the tabs that tabs are part of form)

Issue ManageIQ#6213
    @h-kataria
    h-kataria committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    0feea60 View commit details
    Browse the repository at this point in the history

  3. use console.error instead to log error message 

    Issue ManageIQ#6213
    @h-kataria
    h-kataria committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    b47aa19 View commit details
    Browse the repository at this point in the history