Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow performing operations on Instances of a chosen Network Router #6498

Merged

Conversation

hstastna
Copy link
Contributor

@hstastna hstastna commented Dec 5, 2019

Issue: #6309

This PR fixes the issue regarding Instances displayed through a Network Router's Relationships: nothing happened in the UI for almost all of the operations in the toolbar (tagging and comparing Instances worked).

The logic for operations on nested list of Instances was missing, in network_router controller. I'm adding appropriate logic by using button method from GenericButtonMixin.

In this PR, I'm also adding missing routes for managing policies of selected Instances.

Also Check Compliance of Last Known Configuration on Instances of a chosen Network Router will be working after merging this PR together with #6426 (MERGED).


What else needs to be fixed:


Before: (SmartState Analysis, nothing happens in the UI)
router_before

After: (SSA successfully initiated for selected Instance)
router_after

@hstastna
Copy link
Contributor Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Dec 10, 2019
@martinpovolny
Copy link

The code looks great. I love the new tests.

@ZitaNemeckova : will you have the capacity to test this in the UI, please?

@ZitaNemeckova
Copy link
Contributor

ZitaNemeckova commented Dec 13, 2019

@hstastna I tried to combine this with #6426 and do Check Compliance of Last Known Configuration for a checked Instance in nested view of a Network Router. And it's not working for me.

[----] F, [2019-12-13T10:33:45.028766 #1808:3fd18abe4f38] FATAL -- : Error caught: [NoMethodError] undefined method `validate_check_compliance_queue' for #<ManageIQ::Providers::Openstack::CloudManager::Vm:0x00007fa2f0d0b3b8>
Did you mean?  validates_acceptance_of
/Users/zita/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/activemodel-5.1.7/lib/active_model/attribute_methods.rb:432:in `method_missing'
/ManageIQ/manageiq/app/models/mixins/availability_mixin.rb:24:in `is_available?'
/ManageIQ/manageiq-ui-classic/app/helpers/application_helper.rb:203:in `block in records_support_feature?'
/ManageIQ/manageiq-ui-classic/app/helpers/application_helper.rb:199:in `find'
/ManageIQ/manageiq-ui-classic/app/helpers/application_helper.rb:199:in `records_support_feature?'
/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:603:in `generic_button_operation'
/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:403:in `check_compliance_vms'
/ManageIQ/manageiq-ui-classic/app/controllers/application_controller/ci_processing.rb:935:in `process_vm_buttons'

@hstastna
Copy link
Contributor Author

@ZitaNemeckova Thank you very much. I will check it. Maybe some more changes will be required to make.

@hstastna hstastna force-pushed the Operations_Instances_of_NetworkRouter branch from a3071c2 to c4dcc51 Compare December 13, 2019 12:58
@hstastna
Copy link
Contributor Author

@ZitaNemeckova Now I see, what caused the problem. I forgot to update another PR and to add here network_router controller (as well as security_group).

@hstastna hstastna force-pushed the Operations_Instances_of_NetworkRouter branch from 8898da4 to ee25758 Compare December 13, 2019 13:47
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

Tested in UI. LGTM 👍

@miq-bot
Copy link
Member

miq-bot commented Dec 13, 2019

Checked commits hstastna/manageiq-ui-classic@c4dcc51~...ee25758 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 👍

@martinpovolny martinpovolny added this to the Sprint 127 Ending Jan 6, 2020 milestone Dec 13, 2019
@martinpovolny martinpovolny merged commit 51cf3ba into ManageIQ:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants