New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow performing operations on Instances of a chosen Network Router #6498
Allow performing operations on Instances of a chosen Network Router #6498
Conversation
@miq-bot add_label bug |
The code looks great. I love the new tests. @ZitaNemeckova : will you have the capacity to test this in the UI, please? |
@hstastna I tried to combine this with #6426 and do
|
@ZitaNemeckova Thank you very much. I will check it. Maybe some more changes will be required to make. |
a3071c2
to
c4dcc51
Compare
@ZitaNemeckova Now I see, what caused the problem. I forgot to update another PR and to add here |
8898da4
to
ee25758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
Tested in UI. LGTM 👍
Checked commits hstastna/manageiq-ui-classic@c4dcc51~...ee25758 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Issue: #6309
This PR fixes the issue regarding Instances displayed through a Network Router's Relationships: nothing happened in the UI for almost all of the operations in the toolbar (tagging and comparing Instances worked).
The logic for operations on nested list of Instances was missing, in
network_router
controller. I'm adding appropriate logic by usingbutton
method from GenericButtonMixin.In this PR, I'm also adding missing routes for managing policies of selected Instances.
Also Check Compliance of Last Known Configuration on Instances of a chosen Network Router will be working after merging this PR together with #6426 (MERGED).
What else needs to be fixed:
network_router
controller. The issue regarding buttons will be fixed in another PR. More: No Submit, Cancel buttons for Evacuate selected Instances in a nested list #6480Before: (SmartState Analysis, nothing happens in the UI)
After: (SSA successfully initiated for selected Instance)