[IVANCHUK] Refactor get_rec_cls to get proper record class for various items #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
approved these changes
Jul 28, 2020
Issue: ManageIQ#6263 (cherry picked from commit 4274508)
Issue: ManageIQ#5924 Get proper record class for items displayed through Storage Relationships, also for items displayed through Cluster's Relationships, items in Services Workloads, VMs, Instances, Images displayed through various controllers. (cherry picked from commit 5269ad8)
(cherry picked from commit 673399b)
(cherry picked from commit 33e282f)
(cherry picked from commit cf2f25b)
This reverts commit 751ec53.
Issue: ManageIQ#6263 (cherry picked from commit ef9fed4)
mzazrivec
force-pushed
the
refactor_get_rec_cls_for_ivanchuk
branch
from
b8fa6c1
to
6504ca0
Compare
|
Some comments on commits mzazrivec/manageiq-ui-classic@508df91~...6504ca0 spec/controllers/application_controller/ci_processing_spec.rb
|
|
Checked commits mzazrivec/manageiq-ui-classic@508df91~...6504ca0 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint spec/controllers/ems_cluster_controller_spec.rb
|
|
@mzazrivec Can you update the PR summary to describe the issue this PR is fixing? |
mzazrivec
changed the title
This was referenced Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick / backport of the following 2 PRs #6316 #6224 into ivanchuk. I'm creating a separate PR, because some of the files from 6224 would create a conflict during plain cherry-pick.
One of the nice effects of this backport will be that https://bugzilla.redhat.com/show_bug.cgi?id=1858107 will be fixed (among other bzs probably).