Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credentials and auth angular controllers #9021

Merged

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Jan 11, 2024

Remove unused angular credentials controller and associated haml files. This controller looks like it was used on the old provider forms to handle the credentials fields (#726). Since all the provider forms are now in React we can remove this controller. Example of new React provider form:
Screenshot 2024-01-15 at 10 26 59 AM

Remove unused angular credentials controller and associated haml files. This controller looks like it was used on the old ansible provider forms to handle the auth fields (#2867). Since all the provider forms are now in React we can remove this controller. This is the new React configuration provider form:
Screenshot 2024-01-15 at 10 28 36 AM

Cleared field set focus is now also no longer needed as the functions it defines were only used by these 2 controllers and their haml files.

@miq-bot
Copy link
Member

miq-bot commented Jan 11, 2024

Checked commit GilbertCherrie@c5d0bfa with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@GilbertCherrie GilbertCherrie changed the title Remove credentials angular controller Remove credentials and auth angular controllers Jan 11, 2024
@GilbertCherrie GilbertCherrie changed the title Remove credentials and auth angular controllers Remove old credentials and auth angular controllers Jan 11, 2024
@GilbertCherrie GilbertCherrie changed the title Remove old credentials and auth angular controllers Remove credentials and auth angular controllers Jan 11, 2024
@jeffibm jeffibm merged commit edc1d2d into ManageIQ:master Jan 18, 2024
8 checks passed
@GilbertCherrie GilbertCherrie deleted the remove_credentials_controller branch January 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants