Suspended power_state is "suspended"

[AllenBW]

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670373

look now its all fixed n stuff, you can start a service that is of an unknown or suspended power state

[miq-bot]

Checked commit AllenBW@ba366fd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[himdel]

This changed in #430,

-      return item.power_state === "off" && item.power_status === "suspend_complete";
+      return getPowerState(item) === 'off';

and I'm not seeing any suspended in manageiq core.

Are you sure the state is really consistently suspended for all the providers, or should we check power_status as well?

EDIT: though, I am seeing...

  def vm_count_by_state(state)
    vms.inject(0) { |t, vm| vm.power_state == state ? t + 1 : t }
  end
...
  def total_vms_suspended; vm_count_by_state("suspended"); end

so looks like this should be fine :)

EDIT2: power_status is for services, not vms, and I do have 1 suspended VM with the right power state.

[himdel]

LGTM, works in the UI :)