Updates to Service Explorer, show child services #430
Conversation
|
Thanks @jeff-phillips-18 the changes look great! |
|
@jeff-phillips-18 some of those screens still show the icon near Retires ... but other show Never. Can you confirm that the icon was replaced with Never ? |
|
@serenamarie125 sorry, those were older screenshots. I've updated them. |
jeff-phillips-18
force-pushed
the
services
branch
from
319646d
to
b0175b2
Compare
There was a problem hiding this comment.
Overall LGTM! 🤘
Does this work follow design listed below? I was unable to find a link in either the pts or Jira tickets.
https://github.com/ManageIQ/manageiq-design/blob/master/UX/ui-service/MyServices/design.md
| <a uib-tooltip="{{item.name}}" | ||
| tooltip-placement="bottom" | ||
| tooltip-append-to-body="true" | ||
| tooltip-append-to-body="true" |
There was a problem hiding this comment.
Recommend removing duplicate attribute.
| <div ng-if=(item.retires_on)> | ||
| {{ item.retires_on | date : 'shortDate' }} | ||
| </div> | ||
| <div translate>Never</div> |
There was a problem hiding this comment.
Never will always be shown, might want to throw an ng-if on it as well.
| <div class="col-lg-2 col-md-2 col-sm-2 hidden-xs"> | ||
| <div class="list-view-stacked-item" | ||
| uib-tooltip="{{item.retires_on ? (item.retires_on | date : 'medium') : ('Never' | translate)}}" | ||
| tooltip-append-to-body="true" |
There was a problem hiding this comment.
These three options:
tooltip-append-to-body="true"
tooltip-popup-delay="1000"
tooltip-placement="bottom"
are repeated many times, recommend using the $uibTooltipProvider to reconfigure the default options in each controller
http://angular-ui.github.io/bootstrap/#/modal
There was a problem hiding this comment.
@AllenBW Agreed, but I was reluctant as it would effect all screens. Fast tooltips on list views become annoying as you mouse over rows and the tooltips fly by. Is this something we want throughout the application? Only alternative would be to (as you suggest) configure it in each and every controller.
There was a problem hiding this comment.
@chriskacerguis @serenamarie125 looking for yo 💭
@jeff-phillips-18 I kinda wanta gingerly say throughout application, one view shouldn't yield a drastically different tooltip experience than the other, so if they are too fast as is, yeah lets slow em all down! and given these options appear to be applicable more often than not, we can put the burden of overriding them on each controller rather than risk the inconsistency of attempting to apply them that way...
ALL of this might be beyond the scope of this pr though (your discretion of course). If so, saul good here 🌮
There was a problem hiding this comment.
the only parameter that ought to go global would be the popup delay. The tooltip placement is component dependent as is the append-to-body.
I'm thinking the delay setting application wide would be for another PR as individual settings should then be removed from several places.
There was a problem hiding this comment.
Ah append-to-body yeah, good call on that, tooltip placement though is set to top by default, more places than not we use it on the bottom though, I would think it to would make sense to make the default whatever we use more often throughout the app and override when necessary.
Will make a pt encompassing this work and start on it today (if you're on board and nothing else flares up)
|
Updated per comments. And yes, this is to follow the latest design from https://github.com/ManageIQ/manageiq-design/blob/master/UX/ui-service/MyServices/design.md. I can add the link to Jira and PT. |
|
Checked commits jeff-phillips-18/manageiq-ui-service@abe6775~...fe693bd with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@AllenBW can you check the update? |
|
@chriskacerguis THIS THING IS 🌮 |
|
@AllenBW can you change your approval status? |
jeff-phillips-18
force-pushed
the
services
branch
from
fe693bd
to
8dee4c6
Compare
This PR changes the service explore fields being displayed and adds showing the child services for services that have them.
PT: https://www.pivotaltracker.com/story/show/137174911
Jira: https://patternfly.atlassian.net/browse/CFUX-294
Finishes 137174911
@beanh66 @serenamarie125 @chriskacerguis
@miq-bot add_label euwe/no
@miq-bot add_label ux