Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for service dialog being submitted before entry point code on dynamic fields has completed execution #619

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

eclarizio
Copy link
Member

This fix will simply disable the add to cart button when dynamic fields are processing so that it's not possible to submit the dialog while the automate methods are still running.

https://bugzilla.redhat.com/show_bug.cgi?id=1431688

@jjlangholtz Can you review, please?

/cc @gmcculloug

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Mar 31, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 31, 2017

Checked commit eclarizio@7abbefd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@chriskacerguis chriskacerguis self-assigned this Mar 31, 2017
@gmcculloug
Copy link
Member

Looks good. Would like to have @jjlangholtz review as well.

Copy link
Contributor

@jjlangholtz jjlangholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Nice work with all the additional test coverage.

@chriskacerguis chriskacerguis added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
@chriskacerguis chriskacerguis merged commit 3f8539f into ManageIQ:master Mar 31, 2017
@eclarizio
Copy link
Member Author

@miq-bot add_label euwe/yes

@simaishi
Copy link
Contributor

simaishi commented Apr 4, 2017

@eclarizio @chriskacerguis fine/yes ?

@eclarizio
Copy link
Member Author

@simaishi I think so. The BZ was originally reported against 5.7.0 with a target-release of "cfme-future".

simaishi pushed a commit that referenced this pull request Apr 5, 2017
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
(cherry picked from commit 3f8539f)

https://bugzilla.redhat.com/show_bug.cgi?id=1439313
@simaishi
Copy link
Contributor

simaishi commented Apr 5, 2017

Fine backport details:

$ git log -1
commit de6f95f52992bd0134278936eed6dd590b947626
Author: Chris Kacerguis <chriskacerguis@users.noreply.github.com>
Date:   Fri Mar 31 12:57:16 2017 -0500

    Merge pull request #619 from eclarizio/BZ1431688
    
    Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
    (cherry picked from commit 3f8539ffd53943e61d581c7da032aa52f5633487)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1439313

@simaishi
Copy link
Contributor

@eclarizio There is a conflict backporting to Euwe. Please resolve conflict and create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.

$ git status
On branch 5.7.1
Your branch is up-to-date with 'origin/5.7.1'.
You are currently cherry-picking commit 3f8539f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   client/app/states/marketplace/details/details.html

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   client/app/states/catalogs/details/details.state.js
	both modified:   tests/marketplace-details.state.spec.js

eclarizio pushed a commit to eclarizio/manageiq-ui-service that referenced this pull request Apr 11, 2017
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
eclarizio pushed a commit to eclarizio/manageiq-ui-service that referenced this pull request Apr 11, 2017
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
eclarizio pushed a commit to eclarizio/manageiq-ui-service that referenced this pull request Apr 12, 2017
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
@simaishi
Copy link
Contributor

Backported to Euwe via #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants