-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution #619
Conversation
Checked commit eclarizio@7abbefd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Looks good. Would like to have @jjlangholtz review as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Nice work with all the additional test coverage.
@miq-bot add_label euwe/yes |
@eclarizio @chriskacerguis |
@simaishi I think so. The BZ was originally reported against 5.7.0 with a target-release of "cfme-future". |
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution (cherry picked from commit 3f8539f) https://bugzilla.redhat.com/show_bug.cgi?id=1439313
Fine backport details:
|
@eclarizio There is a conflict backporting to Euwe. Please resolve conflict and create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.
|
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
Backported to Euwe via #668 |
This fix will simply disable the add to cart button when dynamic fields are processing so that it's not possible to submit the dialog while the automate methods are still running.
https://bugzilla.redhat.com/show_bug.cgi?id=1431688
@jjlangholtz Can you review, please?
/cc @gmcculloug
@miq-bot add_label bug