[EUWE] Fix for service dialog being submitted before entry point code on dynamic fields has completed execution #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eclarizio can you take a look at the travis error? |
AllenBW
approved these changes
Apr 12, 2017
Fix for service dialog being submitted before entry point code on dynamic fields has completed execution
eclarizio
force-pushed
the
BZ1431688-Euwe-Backport
branch
from
1460175
to
20f6b32
Compare
|
Checked commit eclarizio@20f6b32 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #619, fixing conflicts from the cherry-pick.
Conflicts were minor, tests were using the incorrect path and the main file that changed in #619 was a different file in Euwe so the changes just needed to be moved over.
/cc @simaishi