Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary locale files #1026

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@mzazrivec
Copy link
Contributor

commented Sep 4, 2019

  • we no longer need .po files under locale/ (except english), all the translations now live in manageiq core
  • we no longer need zanata.xml, we use Transifex now
@codeclimate
Copy link

left a comment

The PR diff size of 6543 lines exceeds the maximum allowed for the inline comments feature.

@miq-bot

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Checked commits mzazrivec/miq_v2v_ui_plugin@986d17b~...a633c19 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐️

@mturley
mturley approved these changes Sep 4, 2019

@mturley mturley merged commit 65d1abe into ManageIQ:master Sep 4, 2019

3 checks passed

Hakiri No security warnings were found.
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mzazrivec mzazrivec deleted the mzazrivec:remove_unnecessary_locale_files branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.