Migration nav item should not have any sub items & should show what's currently in Overview #171
Migration nav item should not have any sub items & should show what's currently in Overview #171
Conversation
@priley86 are we merging into sprint6 or master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllenBW this is looking good 👏
@vconzola I'm wondering about the breadcrumb. Currently as Zika mentioned previously CloudForms isn't utilizing breadcrumbs consistently. Do you think we should keep it? In this case, if we keep it, none of the "crumbs" should be links, they should just show the trail ( since there are no navigatable elements )
@AllenBW we are targeting sprint6 branch. Please feel free to update/remove react router routes accordingly. Thanks!! |
@serenamarie125 @priley86 this is g2g whenever ya'll are! |
Thanks a lot @AllenBW - this was more than expected ;) Code looks fine. Just waiting on breadcrumb confirmation @vconzola @serenamarie125 . |
45da708
to
b546957
Compare
@priley86 on it! |
5193eb4
to
3f8e697
Compare
thanks @AllenBW 🥇 i will go ahead and merge... let's target the PF upgrade in PF-React next if you are up to investigating that...hopefully it resolves the Breadcrumbs design (this was mentioned during the last community meeting i believe). |
@priley86... yeah can up the dep in pfr, thoughts on updating the whole slew of em vs just the one? (leaning update all we can cuz... 🆙 deps are 😀 deps) |
requires #3683 before this can get in...
closes #161 so lets WIP it till then... but please do feedback ah meeeeee so this can be made as perfect as possible for as soon as #3683 makes a movelooks like #3683 made it in! this is g2g
so whats this look like?
updated breadcrumb
but gotta a question...no more questions!@serenamarie125 @vconzola yah want the breadcrumb collapsed as well?@priley86 that other component we dont look atInfrastructureMappings
, yah want it cleaned up in this work as well?