Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Migration nav item should not have any sub items & should show what's currently in Overview #171

Merged
merged 3 commits into from Apr 2, 2018

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Mar 26, 2018

requires #3683 before this can get in...

closes #161 so lets WIP it till then... but please do feedback ah meeeeee so this can be made as perfect as possible for as soon as #3683 makes a move

looks like #3683 made it in! this is g2g

so whats this look like?

migration

updated breadcrumb

screen shot 2018-04-02 at 7 37 37 am

but gotta a question... no more questions!

screen shot 2018-03-26 at 1 46 21 pm

@serenamarie125 @vconzola yah want the breadcrumb collapsed as well?

@priley86 that other component we dont look at InfrastructureMappings, yah want it cleaned up in this work as well?

@AllenBW AllenBW closed this Mar 26, 2018
@AllenBW AllenBW reopened this Mar 26, 2018
@AllenBW
Copy link
Member Author

AllenBW commented Mar 26, 2018

@priley86 are we merging into sprint6 or master?

@AllenBW AllenBW changed the title Enhancement/collaps lnav entry Migration nav item should not have any sub items & should show what's currently in Overview Mar 26, 2018
@AllenBW AllenBW changed the title Migration nav item should not have any sub items & should show what's currently in Overview [WIP] Migration nav item should not have any sub items & should show what's currently in Overview Mar 26, 2018
Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllenBW this is looking good 👏

@vconzola I'm wondering about the breadcrumb. Currently as Zika mentioned previously CloudForms isn't utilizing breadcrumbs consistently. Do you think we should keep it? In this case, if we keep it, none of the "crumbs" should be links, they should just show the trail ( since there are no navigatable elements )

@priley86
Copy link
Member

@AllenBW we are targeting sprint6 branch. Please feel free to update/remove react router routes accordingly. Thanks!!

@AllenBW AllenBW changed the title [WIP] Migration nav item should not have any sub items & should show what's currently in Overview Migration nav item should not have any sub items & should show what's currently in Overview Mar 28, 2018
@AllenBW
Copy link
Member Author

AllenBW commented Mar 28, 2018

@serenamarie125 @priley86 this is g2g whenever ya'll are!

@priley86 priley86 changed the base branch from master to sprint6 March 29, 2018 01:26
@priley86
Copy link
Member

Thanks a lot @AllenBW - this was more than expected ;)

Code looks fine. Just waiting on breadcrumb confirmation @vconzola @serenamarie125 .

@priley86
Copy link
Member

priley86 commented Apr 2, 2018

Hey @AllenBW - can we go ahead and set the Breadcrumb to Compute > Migrate ? I believe @vconzola would prefer this. It would be even nicer if the breadcrumbs had a single arrow like PF Core. I believe we still need to update PF in PF-React to latest if you want to try this...

@AllenBW AllenBW force-pushed the enhancement/collaps-lnav-entry branch from 45da708 to b546957 Compare April 2, 2018 11:13
@AllenBW
Copy link
Member Author

AllenBW commented Apr 2, 2018

@priley86 on it!

@AllenBW AllenBW force-pushed the enhancement/collaps-lnav-entry branch from 5193eb4 to 3f8e697 Compare April 2, 2018 11:38
@AllenBW
Copy link
Member Author

AllenBW commented Apr 2, 2018

screen shot 2018-04-02 at 7 37 37 am

@priley86 @vconzola updated breadcrumb as requested

@priley86
Copy link
Member

priley86 commented Apr 2, 2018

thanks @AllenBW 🥇

i will go ahead and merge... let's target the PF upgrade in PF-React next if you are up to investigating that...hopefully it resolves the Breadcrumbs design (this was mentioned during the last community meeting i believe).

@priley86 priley86 merged commit f820808 into ManageIQ:sprint6 Apr 2, 2018
@AllenBW AllenBW deleted the enhancement/collaps-lnav-entry branch April 2, 2018 12:18
@AllenBW
Copy link
Member Author

AllenBW commented Apr 2, 2018

@priley86... yeah can up the dep in pfr, thoughts on updating the whole slew of em vs just the one? (leaning update all we can cuz... 🆙 deps are 😀 deps)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants