Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

BootstrapSelect - use global jQuery #335

Merged
merged 3 commits into from
May 22, 2018
Merged

BootstrapSelect - use global jQuery #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86578ec
BootstrapSelect - use global jQuery
himdel May 20, 2018
86132a1
eslintrc - mark $ as global
himdel May 22, 2018
c6571c9
regenerate yarn.lock
himdel May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ module.exports = {
'jest/globals': true
},
globals: {
$: true,
__: true,
sprintf: true
sprintf: true,
},
extends: [
'standard',
Expand Down
3 changes: 0 additions & 3 deletions app/javascript/react/screens/App/common/forms/BootstrapSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ import {
} from 'patternfly-react';
import { focus } from 'redux-form';

const $ = require('jquery');
require('bootstrap-select');

export class BootstrapSelect extends React.Component {
constructor(props) {
super(props);
Expand Down
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,9 @@
"stylelint-config-standard": "^18.0.0"
},
"dependencies": {
"bootstrap-select": "~1.12.4",
"classnames": "^2.2.5",
"csv": "^2.0.0",
"file-saver": "^1.3.8",
"jquery": "~3.2.1",
"lodash.orderby": "^4.6.0",
"moment": "^2.22.0",
"numeral": "^2.0.6",
Expand Down
6 changes: 0 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,12 +1357,6 @@ bootstrap-select@1.12.2:
dependencies:
jquery ">=1.8"

bootstrap-select@~1.12.4:
version "1.12.4"
resolved "https://registry.yarnpkg.com/bootstrap-select/-/bootstrap-select-1.12.4.tgz#7f15d3c0ce978868d9c09c70f96624f55fa02ee1"
dependencies:
jquery ">=1.8"

bootstrap-slider-without-jquery@^10.0.0:
version "10.0.0"
resolved "https://registry.yarnpkg.com/bootstrap-slider-without-jquery/-/bootstrap-slider-without-jquery-10.0.0.tgz#5c304461b3b915037c7c118806c8ca08102f5de3"
Expand Down