Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

[#652] Plan Details: Initially sort by VM name #671

Merged
merged 1 commit into from Sep 27, 2018
Merged

[#652] Plan Details: Initially sort by VM name #671

merged 1 commit into from Sep 27, 2018

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Sep 26, 2018

Fixes #652

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2018

Checked commit mturley@add61f0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

AparnaKarve
AparnaKarve approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@AparnaKarve AparnaKarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple fix!

Thanks @mturley

@michaelkro michaelkro merged commit dc2a707 into ManageIQ:master Sep 27, 2018
@mturley mturley deleted the 652-plan-details-sort-order branch September 27, 2018 13:53
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@michaelkro @simaishi
Merge pull request #671 from mturley/652-plan-details-sort-order
767aaa1 
[#652] Plan Details: Initially sort by VM name

(cherry picked from commit dc2a707)
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 767aaa17983b97d3affe3438086723b32bb41489
Author: Michael Ro <mikerodev@gmail.com>
Date:   Thu Sep 27 08:36:33 2018 -0400

    Merge pull request #671 from mturley/652-plan-details-sort-order
    
    [#652] Plan Details: Initially sort by VM name
    
    (cherry picked from commit dc2a7077beee45fa903206ec0aeeb5d61fa6fb58)

@vconzola
Copy link

https://bugzilla.redhat.com/show_bug.cgi?id=1638527

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AparnaKarve AparnaKarve AparnaKarve approved these changes

@michaelkro michaelkro michaelkro approved these changes

Assignees
No one assigned
Labels
hammer/backported Sprint 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mturley @miq-bot @simaishi @vconzola @AparnaKarve @michaelkro