Skip to content

Commit

Permalink
log_backtrace won't print backtrace for MiqException errors
Browse files Browse the repository at this point in the history
See: https://github.com/ManageIQ/manageiq-gems-pending/blob/hammer/lib/gems/pending/util/vmdb-logger.rb#L106

This will still print as an ERROR level but the backtrace will not be printed to the log as this is a known
error condition where the backtrace is not needed.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1729166

Note, embedded ansible was converted to use runner starting in ivanchuk, therefore this is a hammer only change.

See: #18687
  • Loading branch information
jrafanie committed Aug 29, 2019
1 parent 004033c commit 1b4010f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/manageiq/providers/embedded_ansible/provider.rb
Expand Up @@ -11,6 +11,6 @@ class ManageIQ::Providers::EmbeddedAnsible::Provider < ::Provider

def self.raw_connect(base_url, username, password, verify_ssl)
return super if MiqRegion.my_region.role_active?('embedded_ansible')
raise StandardError, 'Embedded ansible is disabled'
raise MiqException::Error, 'Embedded ansible is disabled'
end
end

0 comments on commit 1b4010f

Please sign in to comment.