Log collection creds validation throws "undefined method `[]' for nil:NilClass [ops/log_depot_edit]"

[jkrocil]

Description of problem:
An error page is displayed on log creds validation.

Version-Release number of selected component (if applicable):
Upstream - master.20150127070628_e51ab51

How reproducible:
Always

Steps to Reproduce:

1. Configure > Configuration > Diagnostics > Collect Logs > Edit
2. Add SMB config & creds and click "Validate"

Actual results:
Error page with "undefined method `[]' for nil:NilClass [ops/log_depot_edit]".

Expected results:
Async creds validation is successful.

Additional info:
production.log extract here: https://gist.github.com/jkrocil/1af9740dd856b167d4a1

[Fryguy]

@brandondunne Is this for you?

[bdunne]

@Fryguy I don't think so. It appears @edit, or @edit[:new] is nil. I could change it to fetch_path to make it nicer to read and not blow up, but those were not nil in the past.

@dclarizio Do you know if anything has changed with @edit usage in this area?

[jkrocil]

Note: This happens both in zone-level and appliance-level log collection setup. (and the issue is still present in upstream)

[jrafanie]

Why is @edit[:new] or @edit nil? @h-kataria @dclarizio Any idea in terms of what has changed to @edit recently? Note, @jkrocil opened this in late January. Can someone in the UI team try to recreate this? We need log collection to work.

Note, @brandondunne made a change in 844a3c2 but it's not clear how that caused @edit to change.

Thanks!

[h-kataria]

@jrafanie @brandondunne this issue is caused some of the code that was removed by commit:
844a3c2 Brandon Dunne at 10/27/14 2:17 PM
Remove duplicate Log Depot validation code
Adding following 2 lines back to code fixes the issue, i will create a PR shortly.
id = params[:id] ? params[:id] : "new"
return unless load_edit("logdepot_edit__#{id}","replace_cell__explorer")

[h-kataria]

Fixed by #2183