Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These files should not be executable #10068

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 26, 2016

Fix file permissions on files that should not be executable.

@bdunne
Copy link
Member Author

bdunne commented Jul 26, 2016

@jrafanie @Fryguy Please review

@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2016

Checked commit bdunne@cf65ec1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
8 files checked, 0 offenses detected
Everything looks good. 🏆

@chrisarcand
Copy link
Member

So uh, what about the one literally ending in .exe? 😄

(pe_header_version_info_test.exe)

@bdunne
Copy link
Member Author

bdunne commented Jul 26, 2016

@chrisarcand Honestly, not sure, but being under the test directory I assumed it didn't need to be executable if it is just test data.

@chrisarcand
Copy link
Member

I'm giving you crap :trollface: Seems legit to me

On Tuesday, July 26, 2016, Brandon Dunne notifications@github.com wrote:

@chrisarcand https://github.com/chrisarcand Honestly, not sure, but
being under the test directory I assumed it didn't need to be executable.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10068 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACUWGpVtg409TCrX8ZqCVS4nb5_1HNqtks5qZoYXgaJpZM4JVoYs
.

Chris Arcand
@chrisarcand

@Fryguy Fryguy merged commit d11a3c8 into ManageIQ:master Jul 27, 2016
@Fryguy Fryguy added this to the Sprint 44 Ending Aug 1, 2016 milestone Jul 27, 2016
@Fryguy Fryguy self-assigned this Jul 27, 2016
@bdunne bdunne deleted the fix_permissions branch July 27, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants