Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing button for re-checking authentication status for middleware #10153

Merged
merged 2 commits into from Aug 2, 2016

Conversation

mtho11
Copy link
Contributor

@mtho11 mtho11 commented Jul 29, 2016

Purpose or Intent

Add the authentication re-check button for middleware. [As was just done for several other providers]

recheck-auth

Links

@chessbyte chessbyte changed the title [WIP]Add missing button for re-checking authentication status for middleware [WIP] Add missing button for re-checking authentication status for middleware Jul 30, 2016
@abonas
Copy link
Member

abonas commented Jul 31, 2016

@mtho11 please put the screenshot here in the PR (the one you put in the original issue)
thanks!

@abonas
Copy link
Member

abonas commented Jul 31, 2016

tests failure look unrelated since they are in catalog_bundle_initialization_spec

@abonas
Copy link
Member

abonas commented Jul 31, 2016

@mtho11 I verified the fix, and the functionality works as expected. however the tooltip displays a placeholder instead of the proper string, please see this screenshot.
screenshot at 2016-07-31 18-31-08

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2016

Checked commits mtho11/manageiq@0e56690~...537aee0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
4 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/ems_middleware_center.rb

  • ❗ - Line 65, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
  • ❗ - Line 79, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

@abonas
Copy link
Member

abonas commented Aug 1, 2016

@mtho11 the latest revision works (and looks 😃 ) as expected. imo you can remove wip. then I can move it to miq

@mtho11 mtho11 changed the title [WIP] Add missing button for re-checking authentication status for middleware Add missing button for re-checking authentication status for middleware Aug 1, 2016
@abonas
Copy link
Member

abonas commented Aug 1, 2016

@miq-bot rm_label wip

@abonas
Copy link
Member

abonas commented Aug 1, 2016

@miq-bot assign @chessbyte

@miq-bot miq-bot removed the wip label Aug 1, 2016
@miq-bot miq-bot assigned chessbyte and unassigned abonas Aug 1, 2016
@abonas
Copy link
Member

abonas commented Aug 1, 2016

@chessbyte this is very similar to changes that @AparnaKarve made for other providers

@chessbyte chessbyte merged commit 5822664 into ManageIQ:master Aug 2, 2016
@chessbyte chessbyte added this to the Sprint 44 Ending Aug 1, 2016 milestone Aug 2, 2016
@mtho11 mtho11 deleted the mw_auth_recheck branch August 2, 2016 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants