Add a button for re-checking authentication status for providers

[AparnaKarve]

Addresses a part of #8643.

While the other major UI changes mentioned in #8643 for the ems editors are still underway, we can move forward with this particular change which basically adds a Re-check Authentication button in the EMS Summary screen to update the Authentication status.

[AparnaKarve]

@Fryguy @jrafanie Please review the new method authentication_check_queue in authentication_mixin 7486a14. It's pretty much based on one of the existing _queue methods in that mixin.

[AparnaKarve]

/cc @Ladas @juliancheal

[AparnaKarve]

@miq-bot add_label wip,ui,providers

[jrafanie]

Can you use the nearly identical authentication_check_types_queue?

It's what we call from the schedule worker on a schedule for each model that includes the authentication mixin.

manageiq/app/models/mixins/authentication_mixin.rb

Lines 10 to 13 in fa42171

	zone = MiqServer.my_server.zone
	assoc = name.tableize
	assocs = zone.respond_to?(assoc) ? zone.send(assoc) : []
	assocs.each(&:authentication_check_types_queue)

[jrafanie]

If there's something you can't do, please provide a test or script demonstrating what's missing and I'll try to fix the code to do what you want.

[AparnaKarve]

@jrafanie authentication_check_types_queue works just as great! Thanks for pointing me to this method.
However, the only thing that needs to happen before we can use this method is to make sure that ems types that have authentication types other than default should have this method available - authentications_to_validate.

[jrafanie]

Good point @AparnaKarve.

The concept was that classes could dictate what authentication types it used to authenticate via authentications_to_validate.

Another way is to pass the types, see here. If you don't specify the types, then use authentications_to_validate will be used.

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[AparnaKarve]

@Ladas Can you review this?
I've added the 'Re-check Authentication' button for ems_cloud, ems_infra and ems_container.
As discussed, also updated the alert message - dd94f8b

[Ladas]

@AparnaKarve hm one question, does this recheck authentication of all attached endpoints? E.g. for OpenStack you can have default and events endpoint there, while only amqp can be rechecked

If ^ is working, it looks good to me, though I don't have a space to actually try this now.

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[AparnaKarve]

@Ladas It rechecks authentications of all attached endpoints.
Basically, whatever authentications you see on the Summary page, those will be rechecked.

For e.g - There could be a situation where an OpenStack provider has both default and amqp endpoints defined, so for that provider, both authentications will be rechecked.
Likewise, there could be an OpenStack provider with only the default endpoint defined, in which case only the default authentication will be rechecked.

So just to clarify the above, you cannot "cherry-pick" (for the lack of a better word) what authentication type to recheck.

Does that sound OK to you?

[Ladas]

@AparnaKarve yeah, that sounds good. In that case looks 👍 to me :-)

[miq-bot]

Checked commits AparnaKarve/manageiq@08bb4cb~...d3d58a4 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1
11 files checked, 8 offenses detected

app/controllers/ems_common.rb

• 🔹 - Line 447, Col 121 - Metrics/LineLength - Line is too long. [140/120]
• 🔹 - Line 449, Col 121 - Metrics/LineLength - Line is too long. [167/120]

app/helpers/application_helper/toolbar/ems_cloud_center.rb

• 🔶 - Line 75, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• 🔶 - Line 89, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/ems_container_center.rb

• 🔶 - Line 81, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• 🔶 - Line 95, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/ems_infra_center.rb

• 🔶 - Line 86, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• 🔶 - Line 100, Col 3 - Style/IndentArray - Indent the right bracket the same as the first position after the preceding left parenthesis.

[AparnaKarve]

@Ladas Thanks for the confirmation above.
Now if only I could get a volunteer to test this PR :) -- I would think we do need this for darga.
@Ladas, tbh, you are the perfect candidate to test this... just saying 😉

[AparnaKarve]

@miq-bot remove_label wip

[martinpovolny]

You don't need to create several classes with the same code.

If the behavior you need here just checks for auth status on the record, you can just create 1 class for that and share the class for all the buttons

[abonas]

@AparnaKarve middleware provider seems out of scope for this feature and PR - any reason why?

[AparnaKarve]

@abonas The main reason would be this feature was targeted for Darga.
I can create a separate PR for middleware for this feature.

[abonas]

@abonas The main reason would be this feature was targeted for Darga.
I can create a separate PR for middleware for this feature.

thanks @AparnaKarve , it can definitely be a separate PR.