Memoize image_path helper in build_tags_tree #10181
Conversation
Making the call to `ActionController::Base.helpers.image_path` is expensive, and since this value never changes for each parent and child and in the iteration, saving these before entering the loop saves significant amount of time when N grows large. Here is an example showing a before and after with a DB that includes 15k Tags: Before ------ Started GET "/miq_request/show/:id"... Completed 200 OK in 13204ms (Views: 919.9ms | ActiveRecord: 0.0ms) | ms | bytes | objects | queries | query (ms) | rows | | ---: | ---: | ---: | ---: | ---: | ---: | | 11,811.7 | N/A | 38,383,207 | 78 | 905.3 | 33,593 | After ----- Started GET "/miq_request/show/:id"... Completed 200 OK in 3819ms (Views: 1380.0ms | ActiveRecord: 0.0ms) | ms | bytes | objects | queries | query (ms) | rows | | ---: | ---: | ---: | ---: | ---: | ---: | | 1,974.4 | N/A | 2,146,710 | 78 | 843.9 | 33,593 |
|
Checked commit NickLaMuro@8bf1511 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@NickLaMuro @dmetzger57 @dclarizio should this be backported to Darga? |
|
@chessbyte Sorry about the forgetting labels 😞 As far as darga is concerned, I think it is a simple enough fix with enough speed/memory improvements that it should be an easy and worthwhile backport. It might not hurt having someone from @dclarizio 's team give it a once over though just to make sure I didn't miss something, since |
|
Yes 👍 Sent from my iPhone On Aug 1, 2016, at 10:21 PM, Oleg Barenboim notifications@github.com @NickLaMuro https://github.com/NickLaMuro @dmetzger57 — |
…ld_tags_tree Memoize image_path helper in build_tags_tree (cherry picked from commit 7c2e4ee)
|
Darga backport details: |
Purpose or Intent
Improves the load time of the
/miq_request/show/:idroute for databases with a large number of Tags (over 10k).Overview
Making the call to
ActionController::Base.helpers.image_pathis expensive and is called N times for the total number of tags (parents and children) iterated over inbuild_tags_tree. Since this value never changes for each parent and child and in the iteration, saving these before entering the loop saves significant amount of time and resources when N grows large.Metrics
Here is an example showing a before and after with a DB that includes 15k Tags:
Before
Started GET "/miq_request/show/:id"...
Completed 200 OK in 13204ms (Views: 919.9ms | ActiveRecord: 0.0ms)
After
Started GET "/miq_request/show/:id"...
Completed 200 OK in 3819ms (Views: 1380.0ms | ActiveRecord: 0.0ms)