test relationship.filtered #10314
Merged
test relationship.filtered #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit kbrock@5284e9e with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
| vms.map(&:save!) | ||
| hosts.map(&:save!) | ||
| storages.map(&:save!) | ||
| filtered_results = Relationship.filtered(%w(Host VmOrTemplate), %w(Storage)) |
There was a problem hiding this comment.
why not...
let!(:storages) { FactoryGirl.create_list(:relationship_storage_vmware, 1) }
let!(:vms) { FactoryGirl.create_list(:relationship_vm_vmware, 1) }
let!(:hosts) { FactoryGirl.create_list(:relationship_host_vmware, 1) }
let(:filtered_results) { described_class.filtered(%w(Host VmOrTemplate), %w(Storage))
it "scopes" do
expect(filtered_results).to match_array(vms + hosts)
endThere was a problem hiding this comment.
I've been avoiding let! - want to be obvious in the test what data exists.
the ! is so subtle and makes this hidden. It also creates objects and people refactoring don't know if it is necessary or if someone was just paying attention when adding a test.
Removing the let!(:storage) would still pass the tests, but it would not be testing that storages are not being brought back. So the test would become useless.
|
Marked darga/yes because the previous PR #10288 is marked yes |
chessbyte
pushed a commit
that referenced
this pull request
Aug 23, 2016
test relationship.filtered (cherry picked from commit 4c76438)
|
Darga backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added tests for relationship#filtered
per #10288 (comment)