-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer select 'Discovered virtual machine' as a default folder #11135
No longer select 'Discovered virtual machine' as a default folder #11135
Conversation
@miq-bot add_label providers/vmware/infra, provisioning |
@miq-bot add_label automate |
@gmcculloug, @Fryguy -- Please review --cc @agrare, @tinaafitz |
vm_folder = "#{host_dc.folder_path}/vm" | ||
find_folder("#{vm_folder}/Discovered virtual machine", host_dc) || find_folder(vm_folder, host_dc) | ||
find_folder(vm_folder, host_dc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but you do not need the vm_folder
variable anymore since it is only used once.
find_folder("#{host_dc.folder_path}/vm", host_dc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I only left it there for readability. I'll pull it out though as the find_folder
method will still be easy to read since the string referenced by vm_folder
is much shorter than it originally was.
For VMWare provisioning we allow the root folder as the default when auto placement is set to true https://www.pivotaltracker.com/story/show/130055823
60afbcd
to
8ea3f2a
Compare
Checked commit syncrou@8ea3f2a with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Nice @syncrou ! |
@gmcculloug this seems to be impacting users on darga (#11573) can this be backported? |
No longer select 'Discovered virtual machine' as a default folder (cherry picked from commit 7ac58a9) https://bugzilla.redhat.com/show_bug.cgi?id=1383470
Darga Backport details: $ git log
commit e66c3824aec855dc5b74f3652796f746657a8319
Author: Greg McCullough <gmccullo@redhat.com>
Date: Fri Sep 9 10:39:58 2016 -0400
Merge pull request #11135 from syncrou/remove_discovered_virtual_machine
No longer select 'Discovered virtual machine' as a default folder
(cherry picked from commit 7ac58a9eddd6068e141a166de578834f59bd4441)
https://bugzilla.redhat.com/show_bug.cgi?id=1383470 |
Purpose or Intent
Links
Steps for Testing/QA