Correct format of columns for MiqExpression

[lpichler]

On some places we are using columns in bad format- for separation of columns is correct to use "-".
I need this for #11369
because there is used for parsing column Field.parse and in this case is specs were failing.

I guess that it was ok because method MiqExpression#to_ruby had correct behaviour but MiqExpression#to_sql - but it seems that it was not needed.

with "."

 MiqExpression.new({"=" => {"field" => "MiqWidget.id", "value" => 444}}).to_sql
=>
[
    [0] nil,
    [1] nil,
    [2] {
        :supported_by_sql => false
    }
]


MiqExpression.new({"=" => {"field" => "MiqWidget.id", "value" => 444}}).to_ruby
=>
"<value ref=miqwidget, type=string>/virtual/id</value> == \"444\""




with "-"


MiqExpression.new({"=" => {"field" => "MiqWidget-id", "value" => 444}}).to_sql
=>
[
    [0] "\"miq_widgets\".\"id\" = 444",
    [1] {},
    [2] {
        :supported_by_sql => true
    }
]

MiqExpression.new({"=" => {"field" => "MiqWidget-id", "value" => 444}}).to_ruby
=>
"<value ref=miqwidget, type=integer>/virtual/id</value> == 444"

cc @imtayadeway @alongoldboim

@miq-bot assign @gtanzillo

[miq-bot]

Checked commit lpichler@fdc64a5 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
6 files checked, 1 offense detected

spec/models/miq_schedule_filter_spec.rb

• ❕ - Line 49, Col 121 - Metrics/LineLength - Line is too long. [139/120]

[kbrock]

It looks like it was working by sliding through the sql aspect, and then in ruby doing its work.

This is a bug and thanks for the fix

[kbrock]

/fyi @gtanzillo @imtayadeway this is a bug and I merged it

[gtanzillo]

Thanks @kbrock 👍