UI: Adds network provisioning for Network provider

[gildub]

Views: Added edit and new - using Angular (as cloud_volume)
Button: Adds configuration -> Add, Edit and Cancel
Controllers/Models:
EMS Network Provider updates using raw updates
to be replaced with tasks.

Includes rspec

• Skips the "Edit tag" button

More fields to be added once following fixed:
fog/fog-openstack#192

[tzumainn]

@miq-bot add_label euwe/yes

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[gildub]

@dclarizio, @martinpovolny, @himdel, could you please review?

[himdel]

Minor, but missing space before =..

EDIT: and same in the else branch..

[gildub]

Done, thanks.

[himdel]

Any reason not to use the absolute (/cloud_network/create/new) url here? And why concatenate 2 constants?

[gildub]

Good question and I honestly have no idea, it's the same in many other forms, included the cloud_volume ones I got inspired from.

[himdel]

Aah, you're right .. OK, in that case, I don't care either way, I'll be doing a PR to fix the others anyway :).

[himdel]

Please don't use miqAjaxButton with true (trying to remove in #11324) - pass $scope.cloudNetworkModel instead (or an object with whatever data you want to send to the server in general).

[gildub]

Sure, passing the scope model now.

[himdel]

@gildub I'm also seeing a lot of duplication between edit.html.haml and new.html.haml, any chance these could share a common partial?

[gildub]

@himdel, yes, absolutely!

[gildub]

@himdel, thanks for your help
@dclarizio, I think this one is ready

[himdel]

@gildub any time :) LGTM, except I still wonder about the duplication between new and edit partials. Why do they even have to be different? I do understand that network manager can only be set when adding (although it could still be visible and disabled, so that you can see the type in edit), but Provider Network Type and Cloud Tenant seem like there's no reason not to move them to the shared partial...

IMHO only the javascript part has to be different.

[gildub]

@himdel,

Actually once a network has been created there are fields that cannot be changed, the provider:network_type and tenant/project are among them.

When creating such as in new form those fields are displayed with a dropdown box.
When editing, those fields are displayed in plain only text.

Unless you have a mechanism to make the select read only I don't see any benefit to have those in a common partial where there is going to be a conditional to triage between a plain text or a select depending if it's edit or new.

[tzumainn]

👍 tested the UI; network was created, edited, and deleted correctly

[himdel]

@gildub Well, the mechanism is ng-readonly="newRecord", but.. I'll leave this one up to you. If you consider it more readable and maintainable to have it in two slightly different copies, I'll believe you :).

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[gildub]

@himdel,

Ok for ng-readonly flag, but unfortunately that doesn't work for select as a whole. And even if it did that would mean provide a single value in case of update (readonly) which I think is messy. I suppose a more pure javascript approach would be possible but out of scope for now.

[miq-bot]

Checked commit https://github.com/gildub/manageiq/commit/86475e9e2827ccf3ee7c62366d855a426e442da4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
11 files checked, 28 offenses detected

app/controllers/cloud_network_controller.rb

• ❗ - Line 240, Col 5 - Style/RedundantReturn - Redundant return detected.
• ❗ - Line 250, Col 1 - Style/EmptyLines - Extra blank line detected.
• ❗ - Line 251, Col 36 - Style/NestedModifier - Avoid using nested modifiers.
• ❕ - Line 113, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for delete_networks is too high. [41.58/20]
• ❕ - Line 113, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for delete_networks is too high. [13/6]
• ❕ - Line 113, Col 3 - Metrics/MethodLength - Method has too many lines. [41/25]
• ❕ - Line 113, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for delete_networks is too high. [17/7]
• ❕ - Line 169, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• ❕ - Line 202, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for update is too high. [29.85/20]
• ❕ - Line 202, Col 3 - Metrics/MethodLength - Method has too many lines. [28/25]
• ❕ - Line 243, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for edit_form_params is too high. [57.76/20]
• ❕ - Line 243, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for edit_form_params is too high. [11/6]
• ❕ - Line 243, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for edit_form_params is too high. [11/7]
• ❕ - Line 24, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for button is too high. [31.72/20]
• ❕ - Line 24, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for button is too high. [10/6]
• ❕ - Line 24, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for button is too high. [11/7]
• ❕ - Line 252, Col 121 - Metrics/LineLength - Line is too long. [121/120]
• ❕ - Line 254, Col 121 - Metrics/LineLength - Line is too long. [146/120]
• ❕ - Line 255, Col 121 - Metrics/LineLength - Line is too long. [170/120]
• ❕ - Line 260, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for form_params is too high. [36.85/20]
• ❕ - Line 260, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for form_params is too high. [10/6]
• ❕ - Line 260, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for form_params is too high. [10/7]
• ❕ - Line 70, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for create is too high. [37.76/20]
• ❕ - Line 70, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for create is too high. [8/6]
• ❕ - Line 70, Col 3 - Metrics/MethodLength - Method has too many lines. [38/25]
• ❕ - Line 70, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for create is too high. [8/7]

app/helpers/application_helper/toolbar/cloud_network_center.rb

• ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

app/helpers/application_helper/toolbar/cloud_networks_center.rb

• ❗ - Line 3, Col 5 - Style/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

[chessbyte]

Euwe Backport details:

$ git log
commit 3be35cc1e5ffb75378cb23089449d6d235609f56
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Fri Oct 7 13:48:46 2016 -0700

    Merge pull request #11442 from gildub/network-provisioning-network

    UI: Adds network provisioning for Network provider
    (cherry picked from commit 5c4d9424ec2be2fd2171aac313d63bd5fff9b360)