Added missing routes for Network Ports #11584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, ui |
|
@jzigmund please add tests for these new routes. Thx, Dan |
jzigmund
force-pushed
the
bz1364089-missing_routes_for_network_ports
branch
2 times, most recently
from
fb15d4c
to
9c7e6d4
Compare
jzigmund
force-pushed
the
bz1364089-missing_routes_for_network_ports
branch
from
9c7e6d4
to
b1d451b
Compare
|
@dclarizio test added, updated PR. I've noticed that previous PR, for the BZ, is missing the tests also, so I will create separated PR for that. There is also a space to DRY our routes, as the |
|
Checked commits jzigmund/manageiq@c349c8b~...b1d451b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Oct 21, 2016
…network_ports Added missing routes for Network Ports (cherry picked from commit 93a8790) https://bugzilla.redhat.com/show_bug.cgi?id=1387690
|
Euwe Backport details: $ git log -1
commit 58d97135301087922bbfa750c002f11537f64539
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Thu Oct 20 08:48:37 2016 -1000
Merge pull request #11584 from jzigmund/bz1364089-missing_routes_for_network_ports
Added missing routes for Network Ports
(cherry picked from commit 93a8790aed5fa3640af90ce3b6eb5a4a65968170)
https://bugzilla.redhat.com/show_bug.cgi?id=1387690 |
chessbyte
pushed a commit
that referenced
this pull request
Nov 3, 2016
…network_ports Added missing routes for Network Ports (cherry picked from commit 93a8790) https://bugzilla.redhat.com/show_bug.cgi?id=1370573
|
Darga Backport details: $ git log -1
commit 8ad928567fc07fd0f1535eb69800b4e4f4a27ca8
Author: Dan Clarizio <dclarizi@redhat.com>
Date: Thu Oct 20 08:48:37 2016 -1000
Merge pull request #11584 from jzigmund/bz1364089-missing_routes_for_network_ports
Added missing routes for Network Ports
(cherry picked from commit 93a8790aed5fa3640af90ce3b6eb5a4a65968170)
https://bugzilla.redhat.com/show_bug.cgi?id=1370573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added routes for advanced search in Network Ports
Previous PR that's fixing missing routes for Network* resources:#10324
https://bugzilla.redhat.com/show_bug.cgi?id=1364089