A correct ems_ref for saving #12021
Merged
A correct ems_ref for saving #12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A correct ems_ref for saving, we were providing an id attribute, which didn't exist in the hash, causing this code always delete&create instead of updating of the rows.
|
@blomquisg I am making specs for this in AWS, I actually discovered this bug using the stubbed specs. :-) |
|
Checked commit Ladas@3b92d66 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
chessbyte
pushed a commit
that referenced
this pull request
Oct 19, 2016
A correct ems_ref for saving (cherry picked from commit 91c1c66)
|
Euwe Backport details: $ git log -1
commit 5988f516579c071dcbd03af40309e196e41c65d9
Author: Greg Blomquist <blomquisg@gmail.com>
Date: Tue Oct 18 13:22:57 2016 -0400
Merge pull request #12021 from Ladas/correct_ems_ref_for_saving
A correct ems_ref for saving
(cherry picked from commit 91c1c660ef0e249db6424995299bf379e1cf5857) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A correct ems_ref for saving, we were providing an id attribute,
which didn't exist in the hash, causing this code always
delete&create instead of updating of the rows.