Add uniqueness validation on Endpoint#url #12068
Conversation
| Endpoint.create!(:url => "abc") | ||
| expect { Endpoint.create!(:url => "abc") }.to raise_error("Validation failed: Url has already been taken") | ||
| end | ||
| end |
There was a problem hiding this comment.
TBH, I'm indifferent about these specs. You're essentially testing that ActiveRecord does it's job (which is also why I'm generally against shoulda-matchers. Are you sure you want to add these db writes to the tests? Your choice but thought I'd throw my thoughts out there.
There was a problem hiding this comment.
Yeah, I was on the fence about writing them since it is just testing rails validations.
My only argument for these kinds of tests is that it shows the intent of the validations for people making future changes. It's essentially testing this use case.
- Change duplicate URL which now fails validation - Fix inconsistent hash alignment - Remove unnecessary context https://bugzilla.redhat.com/show_bug.cgi?id=1382627
bdunne
force-pushed
the
ansible_tower_duplicates
branch
from
a10cdb6
to
2a1e51f
Compare
|
Checked commits bdunne/manageiq@b019e53~...2a1e51f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
| controller.instance_variable_set(:@provider_cfgmgmt, provider2) | ||
| allow(controller).to receive(:render_flash) | ||
| controller.save_provider_foreman | ||
| expect(assigns(:flash_array).first[:message]).to include("Configuration_manager.name has already been taken") |
Add uniqueness validation on Endpoint#url (cherry picked from commit 97e2b60) https://bugzilla.redhat.com/show_bug.cgi?id=1382627
|
Euwe Backport details: $ git log -1
commit 13c6d9cfc3c8df082c5a99dddba7b0318b26cec1
Author: Chris Arcand <chrisarcand@users.noreply.github.com>
Date: Thu Oct 20 13:57:54 2016 -0500
Merge pull request #12068 from bdunne/ansible_tower_duplicates
Add uniqueness validation on Endpoint#url
(cherry picked from commit 97e2b60505bba824ea91617afb796f830a85fa77)
https://bugzilla.redhat.com/show_bug.cgi?id=1382627 |
|
@simaishi Please make Euwe BZ from https://bugzilla.redhat.com/show_bug.cgi?id=1382627 |
Don't allow Foreman or AnsibleTower providers to be added multiple times.
https://bugzilla.redhat.com/show_bug.cgi?id=1382627