Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DARGA] New chargeback calculations #12093

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 21, 2016

darga PR for #11648
darga BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1349413
@miq-bot add_label wip

This PR covers only new chargeback calculations as were introduced here

Cherry-pick was not clean because there were touched some features in code of original PR which did not belong to darga.

Last commit 'New chargeback calculations'
is related to #11648 and others commits
are PRs which were needed for it as well.

Example of monthly report, and all rates are hourly and set to $1 with $0 fixed part.

before
screen shot 2016-10-21 at 11 33 46

after

screen shot 2016-10-21 at 11 33 54

gtanzillo and others added 3 commits October 20, 2016 17:38
…s_to_method

Extract getting key and fields to method in chargeback
(cherry picked from commit becd152)
…t_rates_in_chargeback

Use correct adjustment in chargeback reports
(cherry picked from commit 6d02e5f)
…s_to_method

Move reportable metric and cost fields to method
(cherry picked from commit cb340f9)
@lpichler lpichler changed the title [WIP] [DARGA] New chargeback calculations darga [WIP] [DARGA] New chargeback calculations Oct 21, 2016
@miq-bot miq-bot added the wip label Oct 21, 2016
@lpichler lpichler force-pushed the new_chargeback_calculations_darga branch from daef944 to cf21ce4 Compare October 21, 2016 09:18
@miq-bot
Copy link
Member

miq-bot commented Oct 21, 2016

Checked commits lpichler/manageiq@7124a90~...cf21ce4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 0 offenses detected
Everything looks good. 🍪

@lpichler
Copy link
Contributor Author

@miq-bot add_label chargeback, reporting, blocker

@himdel
Copy link
Contributor

himdel commented Oct 21, 2016

darga PR for #12093
This PR covers only new chargeback calculations as were introduced here
is related to #12093 and others commits

@lpichler You're linking to this PR from this PR .. 3 times. You may have wanted to reference a different one maybe?

@lpichler
Copy link
Contributor Author

@himdel updated - exactly 🔁, thanks for noticing!

@lpichler lpichler changed the title [WIP] [DARGA] New chargeback calculations [DARGA] New chargeback calculations Oct 21, 2016
@lpichler
Copy link
Contributor Author

@miq-bot remove_label wip

@lpichler
Copy link
Contributor Author

cc @gtanzillo

@miq-bot miq-bot removed the wip label Oct 21, 2016
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chessbyte chessbyte self-assigned this Oct 22, 2016
@lpichler
Copy link
Contributor Author

@miq-bot add_label darga/yes

@chessbyte chessbyte merged commit bce876c into ManageIQ:darga Nov 4, 2016
@chessbyte chessbyte added this to the Sprint 49 Ending Nov 14, 2016 milestone Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants