Rewritten miq_request view to HAML + added gettext calls #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@5383ee1 with rubocop 0.27.1 |
|
Taking this one for review. Need a beer or two ;-) |
|
Found no issues. Merging. |
martinpovolny
added a commit
that referenced
this pull request
Jan 9, 2015
Rewritten miq_request view to HAML + added gettext calls
Merged
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Jan 12, 2015
Fixed HAML syntax issues/errors introduced in ManageIQ#1227
h-kataria
added a commit
to h-kataria/manageiq
that referenced
this pull request
Jan 16, 2015
Moved code that sets pull down values to correct if/else block, this issue was introduced with haml conversion in ManageIQ#1227 ManageIQ#1375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issues: #1001, #1025