Don't use fetch, when you wish to fetch_path #12468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing: (https://bugzilla.redhat.com/show_bug.cgi?id=1378154) FATAL -- : Error caught: [ArgumentError] wrong number of arguments (3 for 1..2) app/models/vim_performance_analysis.rb:276:in `fetch' app/models/vim_performance_analysis.rb:276:in `block in get_vm_needs' app/models/vim_performance_analysis.rb:276:in `collect' app/models/vim_performance_analysis.rb:276:in `get_vm_needs' app/models/vim_performance_planning.rb:121:in `vm_metric_values' app/controllers/miq_capacity_controller.rb:581:in `planning_get_vm_values' app/controllers/miq_capacity_controller.rb:222:in `planning_option_changed' Introduced in 88c28e0 In retrospect, it we should strive to change only one thing per a commit.
|
Checked commit isimluk@ca27cd0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 app/models/vim_performance_analysis.rb
|
chessbyte
pushed a commit
that referenced
this pull request
Nov 7, 2016
Don't use fetch, when you wish to fetch_path (cherry picked from commit e669263) https://bugzilla.redhat.com/show_bug.cgi?id=1378154
|
Euwe Backport details: $ git log -1
commit de1ddea28cb09c26c412eaa1a6e17870095a2b91
Author: Keenan Brock <keenan@thebrocks.net>
Date: Mon Nov 7 13:46:06 2016 -0500
Merge pull request #12468 from isimluk/fetch_and_fetch_path
Don't use fetch, when you wish to fetch_path
(cherry picked from commit e6692639505e61107cf062b08c7c64b5c620383a)
https://bugzilla.redhat.com/show_bug.cgi?id=1378154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1378154
Addressing:
Introduced in 88c28e0
@miq-bot add_label bug, metrics, euwe/yes, blocker
@miq-bot assign @gtanzillo