Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert size suffixes to decimal version. #12782

Merged
merged 2 commits into from Nov 21, 2016

Conversation

hayesr
Copy link
Contributor

@hayesr hayesr commented Nov 21, 2016

A change to C&U charts caused Javascript spec failures. This alters the specs to be inline with current functionality. @PanSpagetka

@chessbyte this should be backported right after #12640

Related:
https://bugzilla.redhat.com/show_bug.cgi?id=1383821

@himdel
Copy link
Contributor

himdel commented Nov 21, 2016

Relevant.. 18 hours ago, numeral 1.5.4 came out which changed the meaning of the b formatter from KB, MB, GB to KiB, MiB, GiB. 4 hours ago, numeral 1.5.5 came out that restored the previous behaviour (the new one is ib now). PR: adamwdraper/Numeral-js#378

So, we want KB etc., so agreed with the spec change .. and we also want numeral ~> 1.5.5.

@miq-bot
Copy link
Member

miq-bot commented Nov 21, 2016

Checked commits hayesr/manageiq@6c812d3~...81f980c with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🏆

@hayesr
Copy link
Contributor Author

hayesr commented Nov 21, 2016

Restart CI

@hayesr hayesr closed this Nov 21, 2016
@hayesr hayesr reopened this Nov 21, 2016
@hayesr
Copy link
Contributor Author

hayesr commented Nov 21, 2016

Restart

@hayesr hayesr closed this Nov 21, 2016
@hayesr hayesr reopened this Nov 21, 2016
@dclarizio dclarizio merged commit 64101f4 into ManageIQ:master Nov 21, 2016
@dclarizio dclarizio added this to the Sprint 50 Ending Dec 5, 2016 milestone Nov 21, 2016
@hayesr hayesr deleted the fix_byte_suffixes branch November 21, 2016 23:52
simaishi pushed a commit that referenced this pull request Jan 24, 2017
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit b32eddbc3fda5ec1752c385eaf69c80ab4712279
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Nov 21 15:30:46 2016 -0800

    Merge pull request #12782 from hayesr/fix_byte_suffixes
    
    Revert size suffixes to decimal version.
    (cherry picked from commit 64101f46133c88a03cad21e29a4f76629ef15b56)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1416093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants