[WIP] Update Rx.js to version 5 #13255
Conversation
just moving stuff related to rxSubject out ot miq_angular_application.js
npm install -S rxjs@~5.0.1 sed -i 's/\(rxjs.*\)\^/\1~/' package.json
|
Checked commits https://github.com/himdel/manageiq/compare/fa6df9d4291b3352effdcf794ac7e77c91828fed~...6cd217edd21228ab8827e5f3944f2f1b6756503d with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
| @@ -47,8 +47,6 @@ | |||
| "patternfly-timeline": "~1.0.3", | |||
| "phantomjs-polyfill": "~0.0.2", | |||
| "qs": "~0.3.10", | |||
| "rx-angular": "rx.angular#~1.1.3", | |||
There was a problem hiding this comment.
Looks like we will need to begin to remove rx-angular from https://github.com/ManageIQ/ui-components as well
@karelhala ^^
There was a problem hiding this comment.
Well, I'm only really removing it because it is never used..
But it also seems like ui-components is not using Rx at all, so we can just remove the two dependencies..
There was a problem hiding this comment.
Angular RX was in first iteration of ui-components, we had to watch on scope for some changes and it was better to use Rx's observable, instead Angular's (they use setTimeout or something strange in $watch function). But later we did not used it, so feel free to remove it, we'll remove it in ui-components as well.
|
Rx 5 rocks! Looking forward to this PR to be merged. |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
Moved to ManageIQ/manageiq-ui-classic#18 |
Rx.js got a new major version, compliant with the ES observable spec, Angular 2 will depend on it .. we should upgrade :).
The real incompatibility is really small
onNextvsnext, but unifying and separating while at it..WIP mostly because there's no bower package, so depending on #12581