Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move frontend deps from bower to npm #12581

Closed
wants to merge 14 commits into from
Closed

[WIP] Move frontend deps from bower to npm #12581

wants to merge 14 commits into from

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Nov 11, 2016

Bower is slowly dying (no activity whatsoever between Jul 5 and Nov 6 for example), SUI has already moved from bower to npm (yarn), following suit..

checklist:

  • move bower deps to package.json
  • move remaining frontend Gemfile deps to package.json (except for patternfly-sass because sass)
  • make the asset pipeline read node_modules
  • tooling - build
  • tooling - CI
  • tooling - devel
  • docs

@himdel
Copy link
Contributor Author

himdel commented Nov 11, 2016

bower.json -> package.json:

jq '.dependencies' bower.json | sed -e '1d' -e '$d' -e 's/^\s*"/npm install --save '\''/' -e 's/": "/@/' -e 's/",\?$/'\''/' -e 's/ --save \(.*\)$/& || echo \1 >> fail/' | sh

@himdel
Copy link
Contributor Author

himdel commented Nov 16, 2016

also TODO "angular-ui-codemirror": "~0.3.0" (from #12604) .. easy, already does npm ✔️

@himdel
Copy link
Contributor Author

himdel commented Nov 24, 2016

patternfly-sass has npm for 3.14.1 ✔️

@himdel
Copy link
Contributor Author

himdel commented Nov 25, 2016

TODO
npm ERR! No compatible version found: qs-parser@~0.3.10
npm ERR! Valid install targets:
npm ERR! 0.4.6, 0.4.5
✔️

```
jq '.dependencies' bower.json | sed -e '1d' -e '$d' -e 's/^\s*"/npm install --save '\''/' -e 's/": "/@/' -e 's/",$/'\''/' -e 's/ --save \(.*\)$/& || echo \1 >> fail/' | sh
```

Only things that had the same name and version available in npm.
jquery-1.8
jquery.observe_field
spice-html5-bower (version goes from 0.1.6.2 to 1.6.2, because npm doesn't like the fourth number)
xml_display
reverts that commit by sticking the new versions to the right place
@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2016

Checked commits https://github.com/himdel/manageiq/compare/5dafcdc32b57f2c339b2ac47254e7d0a388f0e65~...46da211ecc5fffa0e21ad4c56b53bb7b43c648ba with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@himdel
Copy link
Contributor Author

himdel commented Nov 29, 2016

patternfly-timeline npm is without dist/, needs manual npm install ; sed -i 's/exclude:[^,]*,//' webpack.config.js; webpack call ...

@himdel
Copy link
Contributor Author

himdel commented Nov 29, 2016

require is not defined - array-includes
require is not defined - fetch
module is not defined - moment-timezone
module is not defined - jquery-ui

@miq-bot
Copy link
Member

miq-bot commented Dec 21, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@chessbyte
Copy link
Member

Please re-create PR in https://github.com/ManageIQ/manageiq-ui-classic

@chessbyte chessbyte closed this Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants