Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment the ae_state_retries when on_exit sets retry #13339

Merged
merged 2 commits into from
Jan 3, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Jan 3, 2017

The ae_state_retries is a counter that keeps track of the number of retries. Previously this was not being done when the 'on_exit' method sets the ae_result to retry. With this PR we will increment ae_state_retries when the on_exit method sets the ae_result to retry.

Links

@mkanoor
Copy link
Contributor Author

mkanoor commented Jan 3, 2017

@gmcculloug @tinaafitz
Please review

@miq-bot
Copy link
Member

miq-bot commented Jan 3, 2017

Checked commits mkanoor/manageiq@098176a~...e2150b1 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 🍪

@tinaafitz
Copy link
Member

@mkanoor Looks good.

@gmcculloug gmcculloug merged commit 8bda79e into ManageIQ:master Jan 3, 2017
@gmcculloug gmcculloug added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 3, 2017
simaishi pushed a commit that referenced this pull request Jan 16, 2017
Increment the ae_state_retries when on_exit sets retry
(cherry picked from commit 8bda79e)

https://bugzilla.redhat.com/show_bug.cgi?id=1413769
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 61a1701e590a3a55b09b73e10e5298a04cd8eb5c
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Jan 3 16:32:54 2017 -0500

    Merge pull request #13339 from mkanoor/bugzilla_1368058
    
    Increment the ae_state_retries when on_exit sets retry
    (cherry picked from commit 8bda79ea62e3a623f884fb2577b16492df794cc0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants