Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports: Remove unused cols #13579

Merged
merged 3 commits into from
Feb 11, 2017
Merged

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jan 19, 2017

col_order and Header define which fields are displayed in the ui.
cols defines which fields are brought back from the database.

This PR removes the columns that are not displayed
Other reports bring back name or updated_at/created_at but don't display them.

product/views/Condition.yaml brings back a number of columns, but only displays description I'm questioning whether it is even used.

Please let me know if I've misunderstood the fields in reports.

https://www.pivotaltracker.com/story/show/137377399

@kbrock kbrock requested a review from dclarizio January 19, 2017 02:57
@kbrock kbrock changed the title Report cols condition Remove unused Report cols Jan 19, 2017
@miq-bot
Copy link
Member

miq-bot commented Jan 19, 2017

Checked commits kbrock/manageiq@13f10b9~...308c0e2 with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
0 files checked, 0 offenses detected
Everything looks good. 🍰

@chessbyte
Copy link
Member

@dclarizio @martinpovolny please move product/views to the classic UI repo (in another PR)

@chessbyte chessbyte assigned Fryguy and gtanzillo and unassigned Fryguy Jan 24, 2017
@kbrock kbrock assigned martinpovolny and unassigned gtanzillo Jan 26, 2017
@kbrock kbrock removed the request for review from dclarizio January 26, 2017 18:30
@kbrock kbrock changed the title Remove unused Report cols Reports: Remove unused cols Jan 31, 2017
@martinpovolny martinpovolny merged commit f80becb into ManageIQ:master Feb 11, 2017
@martinpovolny martinpovolny added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 11, 2017
@kbrock kbrock deleted the report_cols_condition branch February 11, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants