Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning for used attributes for query optimizations #14023

Commits on Feb 22, 2017

  1. We want to allow setting references as public

    We want to allow setting references as public
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    d9be0c2 View commit details
    Browse the repository at this point in the history
  2. The constant is written as O(1) not O(C)

    The constant is written as O(1) not O(C)
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    1834f74 View commit details
    Browse the repository at this point in the history
  3. Calling .include? on Set is O(1)

    Calling .include? on Set is O(1)
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    6292eaa View commit details
    Browse the repository at this point in the history
  4. Not relevant comment, attributes is callable multiple times now

    Not relevant comment, attributes is callable multiple times now
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    4245376 View commit details
    Browse the repository at this point in the history
  5. Add ApplicationRecordLite that is for holding is and class of AR

    Add ApplicationRecordLite that is for holding is and class of AR.
    ActiveRecord object are to huge and we need a query to obtain them,
    in most cases we have a class and id, which is just enough
    to fil la relation. No need to go to db.
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    8e8a409 View commit details
    Browse the repository at this point in the history
  6. Collect attribute_references and use them for db strategy

    Collect attribute_references and use them for db strategy.
    So we are able to load a relation fro ma db without making a
    sql query, wrapping it to ApplicationRecordLite.
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    213ddcc View commit details
    Browse the repository at this point in the history
  7. Extract InitDataHelper so it's reusable in other specs

    Extract InitDataHelper so it's reusable in other specs
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    557cf1b View commit details
    Browse the repository at this point in the history
  8. Spec testing a db_find_strategy with :key poiting to relation

    Spec testing a db_find_strategy with :key poiting to relation
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    0eaa8a3 View commit details
    Browse the repository at this point in the history
  9. Autofix rubocop issues

    Autofix rubocop issues
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    0434b75 View commit details
    Browse the repository at this point in the history
  10. Fix a polymorphic relation loading

    Fix a polymorphic relation loading
    Ladas committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    d9bb158 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2017

  1. Test a polymorphic relation is obtained via :key

    Test a polymorphic relation is obtained via :key
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    fdd94b8 View commit details
    Browse the repository at this point in the history
  2. Clean up a spec to only use a needed ICs

    Clean up a spec to only use a needed ICs
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    9cb0f73 View commit details
    Browse the repository at this point in the history
  3. Look for foreign_key only in belongs_to relations

    Look for foreign_key only in belongs_to relations, we would get
    a confusing trying to assign to another relation.
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    bb3dbd8 View commit details
    Browse the repository at this point in the history
  4. Check for allowed strategies

    Check for allowed strategies and raise exception with a list of
    allowed
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    ebc9921 View commit details
    Browse the repository at this point in the history
  5. A complex interconnection spec

    A complex interconnection spec
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    cf20b74 View commit details
    Browse the repository at this point in the history
  6. Enhance specs and run them for both DB strategies

    Enhance specs and run them for both DB strategies
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    d26d696 View commit details
    Browse the repository at this point in the history
  7. Autofix rubocop issues

    Autofix rubocop issues
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    3d976da View commit details
    Browse the repository at this point in the history
  8. Rename ApplicationRecordLite to ApplicationRecordReference

    Rename ApplicationRecordLite to ApplicationRecordReference, as
    it shows the purpose much better.
    Ladas committed Feb 23, 2017
    Configuration menu
    Copy the full SHA
    19e7dcc View commit details
    Browse the repository at this point in the history