Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUWE] Backport for Fix for Service Dialog not saving default value <None> for drop down or radio button #14259

Merged
merged 3 commits into from Mar 10, 2017
Merged

[EUWE] Backport for Fix for Service Dialog not saving default value <None> for drop down or radio button #14259

merged 3 commits into from Mar 10, 2017

Commits on Mar 9, 2017

  1. Merge pull request ManageIQ#14240 from eclarizio/BZ1428133 

    Fix for Service Dialog not saving default value <None> for drop down or radio button
(cherry-picked from commit a912f50)

https://bugzilla.redhat.com/show_bug.cgi?id=1428133
    @gmcculloug @eclarizio
    gmcculloug authored and eclarizio committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    16674f7 View commit details
    Browse the repository at this point in the history

  2. Do not prepend 'none' option to values as it is done in the model now 

    https://bugzilla.redhat.com/show_bug.cgi?id=1428133

Continue to prepend 'none' option for radio buttons while editing the
field, because it should still be a default value option, but we do not
want to actually display a radio button with a "None" option, they can
simply leave it un-checked

Manually patched from commit 1962209
from the classic-UI repo.
    @eclarizio
    eclarizio committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    e098462 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2017

  1. Fix for test failures due to 'values' method now adding nil options 

    https://bugzilla.redhat.com/show_bug.cgi?id=1428133
    @eclarizio
    eclarizio committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    f16bc1b View commit details
    Browse the repository at this point in the history