[EUWE] Backport for Fix for Service Dialog not saving default value <None> for drop down or radio button #14259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Service Dialog not saving default value <None> for drop down or radio button (cherry-picked from commit a912f50) https://bugzilla.redhat.com/show_bug.cgi?id=1428133
https://bugzilla.redhat.com/show_bug.cgi?id=1428133 Continue to prepend 'none' option for radio buttons while editing the field, because it should still be a default value option, but we do not want to actually display a radio button with a "None" option, they can simply leave it un-checked Manually patched from commit 1962209 from the classic-UI repo.
gmcculloug
reviewed
Mar 10, 2017
eclarizio
force-pushed
the
Backport_for_BZ1428133
branch
2 times, most recently
from
cabeba8
to
4e4104e
Compare
eclarizio
force-pushed
the
Backport_for_BZ1428133
branch
from
4e4104e
to
f16bc1b
Compare
|
Checked commits eclarizio/manageiq@16674f7~...f16bc1b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This was referenced Mar 10, 2017
agrare
pushed a commit
to agrare/manageiq
that referenced
this pull request
Apr 19, 2017
[EUWE] Backport for Fix for Service Dialog not saving default value <None> for drop down or radio button (cherry picked from commit 57a70dc) https://bugzilla.redhat.com/show_bug.cgi?id=1430937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backport includes the code from #14240 and the UI side from ManageIQ/manageiq-ui-classic#633.
Conflicts on main repo side were minor, but I had to manually patch the UI side as there was a change in one of the files that didn't allow
git applyorgit amto even try to process the whole file.@gmcculloug Not sure what other labels should be added here, if any. Also assigning you but if someone else should be then please change it 馃槃
/cc @simaishi
@miq-bot assign @gmcculloug
@miq-bot add_label bug