Merge service template options on update #14314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Mar 14, 2017
| @@ -458,8 +458,8 @@ def resource_action_list | |||
| ] | |||
| end | |||
|
|
|||
| def update_from_options(options) | |||
| update_attributes!(options.except(:config_info).merge(:options => { :config_info => options[:config_info] })) | |||
| def update_from_options(params) | |||
There was a problem hiding this comment.
Will this help a little bit of readability?
options[:config_info] = params[:config_info]
update_attributes!(params.except(:config_info))
|
Checked commit jntullo@bfeda5d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bzwei
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @bzwei pointed out, we should not assume that
:config_infois the only key withinoptions, and therefore the options should be merged.@miq-bot add_label services
@miq-bot assign @gmcculloug