Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete and update configuration script sources #14323

Merged
merged 2 commits into from
Mar 16, 2017
Merged

delete and update configuration script sources #14323

merged 2 commits into from
Mar 16, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Mar 14, 2017

Delete and Update Configuration Script Sources via delete_in_provider_queue and update_in_provider_queue

Depends on #14305
@miq-bot add_label enhancement, wip, api
@miq-bot assign @abellotti

@jntullo jntullo changed the title [WIP] delete and update configuration script sources delete and update configuration script sources Mar 14, 2017
@jntullo
Copy link
Author

jntullo commented Mar 14, 2017

@miq-bot remove_label wip

@miq-bot miq-bot removed the wip label Mar 14, 2017
just gp

update message
@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2017

Checked commits jntullo/manageiq@b4102f7~...10bfe0d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 🍪

@abellotti
Copy link
Member

@jntullo This is looking great !! 😍

Thanks for the API enhancement !!

@abellotti abellotti merged commit 19d6bd5 into ManageIQ:master Mar 16, 2017
@abellotti abellotti added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 16, 2017
@himdel
Copy link
Contributor

himdel commented Mar 17, 2017

@jntullo The PUT method is still not enabled, meaning we can't really edit items using the preferred way. Can you fix please? :)

@jntullo jntullo deleted the enhancement/update_delete_config_scrpt_srcs branch November 28, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants