Move bower to ui-classic #14536
Merged
Move bower to ui-classic #14536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label euwe/no, technical debt |
|
This pull request is not mergeable. Please rebase and repush. |
Assets live there, bower (now) lives there, no point in having the initializer in manageiq proper
manageiq travis should no longer depend on bower & assets, since #13801 and bower configs have moved to ui-classic
The update:bower task is defined in ui-classic. The bin/* change is needed because running rake before bundle install is ..problematic :).
|
Checked commits https://github.com/himdel/manageiq/compare/488be60745968d7de64b32191901d0c0cf4ce2ff~...d6296e6ed4f560e1a6c56757c6bb3c25129f196b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel : 👍 🥇 Thanks for this! One more step towards moving to Angular2. Let me buy you a 🍺 on our next team steak session! |
simaishi
added a commit
to simaishi/manageiq-appliance-build
that referenced
this pull request
Mar 31, 2017
fbladilo
added a commit
to fbladilo/manageiq-pods
that referenced
this pull request
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together with ManageIQ/manageiq-ui-classic#823
Right now, bower.json lives in manageiq (except for travis). Mostly because bin/update and bin/setup couldn't handle reading bower.json from manageiq-ui-classic, because ..how do you find where it is :).
This PR removes all traces of bower from manageiq (except for the ignores, because people tend to switch branches :)), moving it to manageiq-ui-classic.
Instead of
bower install -F ...we now runrake update:bower, a task which lives in ui-classic.The change to
bin/updateandbin/setupis needed because running rake tasks is a bit easier afterbundle installthan before :).This also removes caching of
bower_componentsfrom manageiq travis, should not be needed since #13801.@bdunne Can you take a look please? :)