Refactor MiqTask.delete_older to queue condition instead of array of IDs #15415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
added-delete-by-condition-to-miq-task
branch
2 times, most recently
from
aae9c4b
to
dce3744
Compare
…ueue destroy for those id). If queue is busy then there are could be several request to delete task with the same id. Instead queue actual condition to filter record and execute destroy_all. https://bugzilla.redhat.com/show_bug.cgi?id=1397247
yrudman
force-pushed
the
added-delete-by-condition-to-miq-task
branch
from
dce3744
to
d1435a5
Compare
yrudman
changed the title
|
Checked commits yrudman/manageiq@ad3525f~...d1435a5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
yrudman
changed the title
|
@miq-bot assign @gtanzillo |
simaishi
pushed a commit
that referenced
this pull request
Feb 28, 2018
…iq-task Refactor MiqTask.delete_older to queue condition instead of array of IDs (cherry picked from commit ed1af7c) https://bugzilla.redhat.com/show_bug.cgi?id=1550276
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ion-to-miq-task Refactor MiqTask.delete_older to queue condition instead of array of IDs (cherry picked from commit ed1af7c) https://bugzilla.redhat.com/show_bug.cgi?id=1550276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting old tasks records executed in 2 steps: Execute SQL to get list of IDs which need to be deleted (based on passed condition and date) and queue request to
MiqTask.destroywith array of IDs as argument.Issue: when executed on schedule (deleting performance rollup tasks) there is possibility that second request to delete old task could be added to
MiqQueuebefore first request executed. So, in the second request some IDs will be from the first request and attempt to destroy record by id second time will raise error.BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1397247
Solution: Instead of queuing list of IDs to destroy - queue actual condition. Also, It would be better from performance perspective.
@miq-bot add-label bug, core