Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rule for network manager to belongsto filter #16063

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Sep 27, 2017

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1487179
ManageIQ/manageiq-ui-classic#2266 - removing old way - not needed for this PR

@miq-bot assign @gtanzillo

@miq-bot miq-bot added the wip label Sep 27, 2017
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2017

Checked commits lpichler/manageiq@95a23be~...847cbcd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@lpichler lpichler changed the title [WIP] Move rule for network manager to belonsto filter Move rule for network manager to belonsto filter Oct 2, 2017
@miq-bot miq-bot removed the wip label Oct 2, 2017
@lpichler
Copy link
Contributor Author

lpichler commented Oct 2, 2017

@miq-bot add_label rbac, bug, blocker

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@gtanzillo gtanzillo added this to the Sprint 70 Ending Oct 2, 2017 milestone Oct 2, 2017
@gtanzillo gtanzillo merged commit 99eaef8 into ManageIQ:master Oct 2, 2017
@lpichler lpichler deleted the move_rule_for_network_manager_to_belonsto_filter branch October 2, 2017 18:05
simaishi pushed a commit that referenced this pull request Oct 2, 2017
…_to_belonsto_filter

Move rule for network manager to belonsto filter
(cherry picked from commit 99eaef8)

https://bugzilla.redhat.com/show_bug.cgi?id=1497835
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2017

Fine backport details:

$ git log -1
commit c59f3dbe2692fbf98f91ee05725aebc336b0f612
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Oct 2 13:58:25 2017 -0400

    Merge pull request #16063 from lpichler/move_rule_for_network_manager_to_belonsto_filter
    
    Move rule for network manager to belonsto filter
    (cherry picked from commit 99eaef8ab5501db652b2dcec01935452e3e3ce7c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1497835

simaishi pushed a commit that referenced this pull request Oct 3, 2017
…_to_belonsto_filter

Move rule for network manager to belonsto filter
(cherry picked from commit 99eaef8)

https://bugzilla.redhat.com/show_bug.cgi?id=1498095
@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2017

Euwe backport details:

$ git log -1
commit f064d41a96424620f63f90223db8f87268419e94
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Oct 2 13:58:25 2017 -0400

    Merge pull request #16063 from lpichler/move_rule_for_network_manager_to_belonsto_filter
    
    Move rule for network manager to belonsto filter
    (cherry picked from commit 99eaef8ab5501db652b2dcec01935452e3e3ce7c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498095

@chessbyte chessbyte changed the title Move rule for network manager to belonsto filter Move rule for network manager to belongsto filter Oct 14, 2017
d-m-u pushed a commit to d-m-u/manageiq that referenced this pull request Jun 6, 2018
…_manager_to_belonsto_filter

Move rule for network manager to belonsto filter
(cherry picked from commit 99eaef8)

https://bugzilla.redhat.com/show_bug.cgi?id=1497835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants