Do unassign tags when mapped tags list becomes empty #16370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.blank? check was a bug, it also skipped retagging given empty array. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1508437
23 tasks
|
Checked commit cben@5bc81aa with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM 👍 |
agrare
approved these changes
Nov 1, 2017
|
Yep. We have some tests for |
simaishi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Do unassign tags when mapped tags list becomes empty (cherry picked from commit 48675e0) https://bugzilla.redhat.com/show_bug.cgi?id=1510095
|
Gaprindashvili backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 13, 2017
Do unassign tags when mapped tags list becomes empty (cherry picked from commit 48675e0) https://bugzilla.redhat.com/show_bug.cgi?id=1510096
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Do unassign tags when mapped tags list becomes empty (cherry picked from commit 48675e0) https://bugzilla.redhat.com/show_bug.cgi?id=1510096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.blank? check was a bug, it also skipped retagging given empty array.
Fixes
https://bugzilla.redhat.com/show_bug.cgi?id=1508437 (master)
https://bugzilla.redhat.com/show_bug.cgi?id=1510095 (gaprindashvili)
https://bugzilla.redhat.com/show_bug.cgi?id=1510096 (fine)
@miq-bot add-label bug, fine/yes, gaprindashvili/yes
@djberg96 @agrare Tiny but important fix, please review.