Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Enable Web Console on RHOS provider #16609

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

bmclaughlin
Copy link
Contributor

@bmclaughlin bmclaughlin commented Dec 6, 2017

This PR needs to be merged before ManageIQ/manageiq-ui-classic#2039 can be backported to FINE.

Cherry-picked refactorings from the upstream PR #15901 to enable the Web Console on RHOS.

@miq-bot add_labels bug, core, ui

https://bugzilla.redhat.com/show_bug.cgi?id=1496903

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2017

Checked commit bmclaughlin@1dc9769 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Fine to me @simaishi

@simaishi simaishi merged commit e9b3a2a into ManageIQ:fine Dec 7, 2017
@simaishi simaishi added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017
@bmclaughlin bmclaughlin deleted the fine-enable-cockpit-on-rhos branch December 8, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants