[FINE] convert Vm#miq_provision_template to has_one #17309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Field` was extracted it was attractive to let it be a middleman between `MiqExpression` and the Arel library since everything goes through `Field#arel_attribute`. While this started out as straightforward delegation, more supporting code was required to bridge more complex expressions such as `CONTAINS`, or things that require extra arguments like `matches`, etc.. I think that consequently `Field` (and `Tag`) have taken too much on in terms of responsibility. It also introduced a cohesion problem in that not all fields are concerned with columns in the database. While this change might be a step back for `MiqExpression`, I think it greatly improves `Field`. I think there are better patterns out there for better separating responsibilities here, but that can be left to a future revision.
convert Vm#miq_provision_template to has_one (cherry picked from commit eef19e0)
|
Checked commits kbrock/manageiq@158b35b~...d68a133 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 lib/miq_expression.rb
lib/miq_expression/field.rb
lib/miq_expression/where_extraction_visitor.rb
|
simaishi
changed the title
kbrock
requested review from
imtayadeway and
gtanzillo
and removed request for
gtanzillo
|
@miq-bot add_label blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport to fine
vm_or_templatehttps://bugzilla.redhat.com/show_bug.cgi?id=1566528