Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check for report.extras on save hooks #17605

Merged
merged 1 commit into from Jun 19, 2018
Merged

Add nil check for report.extras on save hooks #17605

merged 1 commit into from Jun 19, 2018

Conversation

NickLaMuro
Copy link
Member

@NickLaMuro NickLaMuro mentioned this pull request Jun 19, 2018
Merged
@jrafanie
Copy link
Member

Wow, that looks like it took a while to figure out...

@jrafanie jrafanie self-assigned this Jun 19, 2018
@jrafanie jrafanie merged commit 8a6adec into ManageIQ:master Jun 19, 2018
@jrafanie jrafanie added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 19, 2018
@jrafanie jrafanie added the bug label Jun 19, 2018
@NickLaMuro
Copy link
Member Author

@jrafanie Nah, this wasn't as bad as the ones caused in ManageIQ/manageiq-ui-classic#4143 , just frustrating because I had just finished fixing those, and then these popped up.

Glad we were able to catch them quickly though. 🎉

@jrafanie
Copy link
Member

@miq-bot add_label fine/yes

simaishi pushed a commit that referenced this pull request Jun 22, 2018
@jrafanie @simaishi
Merge pull request #17605 from NickLaMuro/fix_specs_and_issues_from_m…
44dd61a 
…iq_report_result_save_hooks

Add `nil` check for report.extras on save hooks
(cherry picked from commit 8a6adec)

https://bugzilla.redhat.com/show_bug.cgi?id=1594387
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 44dd61ae10c84b4cd6d07bf69a70d8282b0b1358
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Jun 18 21:49:59 2018 -0400

    Merge pull request #17605 from NickLaMuro/fix_specs_and_issues_from_miq_report_result_save_hooks
    
    Add `nil` check for report.extras on save hooks
    (cherry picked from commit 8a6adec06ba3fda7efc37fb42ca2af1ea44e6b92)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1594387

simaishi pushed a commit that referenced this pull request Jun 22, 2018
@jrafanie @simaishi
Merge pull request #17605 from NickLaMuro/fix_specs_and_issues_from_m…
b7b1335 
…iq_report_result_save_hooks

Add `nil` check for report.extras on save hooks
(cherry picked from commit 8a6adec)

https://bugzilla.redhat.com/show_bug.cgi?id=1594386
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit b7b13357292eb7b052ad429894ec941ecff3a3d0
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Jun 18 21:49:59 2018 -0400

    Merge pull request #17605 from NickLaMuro/fix_specs_and_issues_from_miq_report_result_save_hooks
    
    Add `nil` check for report.extras on save hooks
    (cherry picked from commit 8a6adec06ba3fda7efc37fb42ca2af1ea44e6b92)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1594386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrafanie jrafanie

Labels
blocker bug core/reporting fine/backported gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NickLaMuro @jrafanie @simaishi @miq-bot